Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backport patch for webaudio #20924

Merged
merged 2 commits into from Nov 1, 2019

Conversation

@deepak1556
Copy link
Member

deepak1556 commented Nov 1, 2019

Description of Change

Backports https://chromium-review.googlesource.com/c/chromium/src/+/1890494

Checklist

Release Notes

Notes: backport webaudio security patch from upstream

@deepak1556 deepak1556 added the 6-1-x label Nov 1, 2019
@deepak1556 deepak1556 requested review from electron/wg-releases Nov 1, 2019
@deepak1556 deepak1556 requested a review from electron/wg-upgrades as a code owner Nov 1, 2019
Copy link
Member

codebytere left a comment

Is this already present in 7/8?

@deepak1556

This comment has been minimized.

Copy link
Member Author

deepak1556 commented Nov 1, 2019

@codebytere yup the fix has been landed in those versions.

@ppontes
ppontes approved these changes Nov 1, 2019
@deepak1556

This comment has been minimized.

Copy link
Member Author

deepak1556 commented Nov 1, 2019

Failing tests are not related, merging.

@deepak1556 deepak1556 merged commit 1591e13 into 6-1-x Nov 1, 2019
13 of 16 checks passed
13 of 16 checks passed
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-woa-testing Build #20191101.24 had test failures
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
electron-arm-testing Build #20191101.39 succeeded
Details
electron-arm64-testing Build #20191101.39 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Nov 1, 2019

Release Notes Persisted

backport webaudio security patch from upstream

@deepak1556 deepak1556 deleted the robo/6_1_webaudio branch Nov 1, 2019
@sofianguy sofianguy added this to Fixed in 6.1.4 in 6.1.x Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
6.1.x
Fixed in 6.1.4
4 participants
You can’t perform that action at this time.