Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't copy tray image when it's set #20935

Conversation

@trop
Copy link
Contributor

trop bot commented Nov 2, 2019

Backport of #20904

See that PR for details.

Notes: Fixed a memory leak issue when setting Tray images.

@trop trop bot referenced this pull request Nov 2, 2019
4 of 4 tasks complete
@trop trop bot added 7-0-x backport labels Nov 2, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Nov 2, 2019
@MarshallOfSound MarshallOfSound merged commit 37c1df6 into 7-0-x Nov 4, 2019
16 checks passed
16 checks passed
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191102.13 succeeded
Details
electron-arm64-testing Build #20191102.13 succeeded
Details
electron-woa-testing Build #20191102.12 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Nov 4, 2019

Release Notes Persisted

Fixed a memory leak issue when setting Tray images.

@MarshallOfSound MarshallOfSound deleted the trop/7-0-x-bp-fix-don-t-copy-tray-image-when-it-s-set-1572732912368 branch Nov 4, 2019
@deepak1556

This comment has been minimized.

Copy link
Member

deepak1556 commented Nov 7, 2019

@codebytere Should have targeted 7-1-x :)

@codebytere

This comment has been minimized.

Copy link
Member

codebytere commented Nov 7, 2019

/trop run backport-to 7-1-x

@trop

This comment has been minimized.

Copy link
Contributor Author

trop bot commented Nov 7, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "7-1-x" here we go! :D

@trop

This comment has been minimized.

Copy link
Contributor Author

trop bot commented Nov 7, 2019

I was unable to backport this PR to "7-1-x" cleanly;
you will need to perform this backport manually.

@trop trop bot added the needs-manual-bp/7-1-x label Nov 7, 2019
MarshallOfSound added a commit that referenced this pull request Nov 7, 2019
This reverts commit 37c1df6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.