Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: capture the promise global to avoid userland mutation #20947

Merged
merged 2 commits into from Nov 4, 2019

Conversation

@MarshallOfSound
Copy link
Member

MarshallOfSound commented Nov 4, 2019

Backport of #20925 see that PR for details.

Notes: Fixed issue where proxied remote promises might not resolve if Bluebird was installed in the renderer

@trop trop bot added 7-0-x backport labels Nov 4, 2019
@MarshallOfSound MarshallOfSound changed the title fix: capture the promise global to avoid userland mutation (#20925) fix: capture the promise global to avoid userland mutation Nov 4, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Nov 4, 2019
@MarshallOfSound MarshallOfSound changed the base branch from 7-0-x to 7-1-x Nov 4, 2019
@trop trop bot added the 7-1-x label Nov 4, 2019
@MarshallOfSound MarshallOfSound removed the 7-0-x label Nov 4, 2019
@MarshallOfSound MarshallOfSound merged commit 4900923 into 7-1-x Nov 4, 2019
13 of 16 checks passed
13 of 16 checks passed
electron-woa-testing
Details
appveyor: win-ia32-testing Waiting for AppVeyor build to complete
Details
appveyor: win-x64-testing Waiting for AppVeyor build to complete
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191104.47 succeeded
Details
electron-arm64-testing Build #20191104.47 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@MarshallOfSound MarshallOfSound deleted the capture-the-promise-global-7 branch Nov 4, 2019
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Nov 4, 2019

Release Notes Persisted

Fixed issue where proxied remote promises might not resolve if Bluebird was installed in the renderer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.