Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proper i18n of recentDocuments item #20957

Conversation

@trop
Copy link
Contributor

trop bot commented Nov 4, 2019

Backport of #20948

See that PR for details.

Notes: Fixed improper label internationalization for the recentDocuments MenuItem.

@trop trop bot referenced this pull request Nov 4, 2019
4 of 4 tasks complete
@trop trop bot added 7-0-x backport labels Nov 4, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Nov 4, 2019
@MarshallOfSound MarshallOfSound changed the base branch from 7-0-x to 7-1-x Nov 4, 2019
@MarshallOfSound MarshallOfSound added 7-1-x and removed 7-0-x labels Nov 4, 2019
@codebytere codebytere merged commit 6871b44 into 7-1-x Nov 6, 2019
13 of 16 checks passed
13 of 16 checks passed
appveyor: win-ia32-testing AppVeyor build failed
Details
electron-arm-testing Build #20191104.41 failed
Details
electron-arm64-testing Build #20191104.39 failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-woa-testing Build #20191104.31 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Nov 6, 2019

Release Notes Persisted

Fixed improper label internationalization for the recentDocuments MenuItem.

@codebytere codebytere deleted the trop/7-0-x-bp-fix-proper-i18n-of-recentdocuments-item-1572906044286 branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.