Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot access nativeTheme via electron.remote #20961

Merged
merged 1 commit into from Nov 5, 2019

Conversation

@miniak
Copy link
Contributor

miniak commented Nov 4, 2019

Backport of #20938

See that PR for details.

Notes: Fixed nativeTheme not accessible via the remote module.

@miniak miniak self-assigned this Nov 4, 2019
@trop trop bot mentioned this pull request Nov 4, 2019
5 of 5 tasks complete
@miniak miniak changed the title fix: cannot access nativeTheme via electron.remote (#20938) fix: cannot access nativeTheme via electron.remote Nov 4, 2019
@MarshallOfSound MarshallOfSound merged commit 317f0ce into 7-1-x Nov 5, 2019
12 of 15 checks passed
12 of 15 checks passed
appveyor: win-ia32-testing Waiting for AppVeyor build to complete
Details
appveyor: win-woa-testing Waiting for AppVeyor build to complete
Details
appveyor: win-x64-testing Waiting for AppVeyor build to complete
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191105.1 succeeded
Details
electron-arm64-testing Build #20191105.1 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Nov 5, 2019

Release Notes Persisted

Fixed nativeTheme not accessible via the remote module.

@MarshallOfSound MarshallOfSound deleted the miniak/remote-native-theme-7-0-x branch Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.