Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
fix: disable more private macOS APIs in MAS build #20965
Description of Change
This PR disables following private macOS APIs used in Chromium:
Chromium has 2 ways of rendering on macOS: one is using official
This PR forces using
More information can be found at https://bugs.chromium.org/p/chromium/issues/detail?id=312462.
All related code using this class are disabled. It would affect accessibility when remote layer API is used, but we should be fine since remote layer API is disabled too.
Chromium overrides these private classes to implement custom frame. All related code are disabled so custom frame would not work.
Since in Electron we only support standard frame and simple frameless window, we are not affected.
Chromium uses it to guess mime type from extension names, the iOS version of Chromium does not use it. The fallback detection should be enough for us.
Notes: Fix Electron apps getting rejected to Mac App Store.
deepak1556 left a comment •
Thanks @zcbenz !
The RemoteMacViews are gonna stay for a long time https://bugs.chromium.org/p/chromium/issues/detail?id=859152
We should look into the possibility of pushing the remote implementation behind a buildflag in upstream to reduce our patch in future. Thoughts ?
Status update: as disabling remote layer APIs might drag down performance significantly, we are currently waiting for responses from Apple to see if it is possible to unblock