Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade ts generator for better type safety #20975

Merged
merged 2 commits into from Nov 5, 2019

Conversation

@MarshallOfSound
Copy link
Member

MarshallOfSound commented Nov 5, 2019

Fixes a // FIXME in the ts generator that I kinda left unfixed.

Notes: no-notes

@MarshallOfSound MarshallOfSound merged commit fcee721 into master Nov 5, 2019
11 of 15 checks passed
11 of 15 checks passed
appveyor: win-ia32-testing Waiting for AppVeyor build to complete
Details
appveyor: win-woa-testing Waiting for AppVeyor build to complete
Details
appveyor: win-x64-testing Waiting for AppVeyor build to complete
Details
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191105.33 succeeded
Details
electron-arm64-testing Build #20191105.32 succeeded
Details
electron-woa-testing Build #20191105.25 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@MarshallOfSound MarshallOfSound deleted the even-betterer-types branch Nov 5, 2019
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Nov 5, 2019

No Release Notes

@MarshallOfSound

This comment has been minimized.

Copy link
Member Author

MarshallOfSound commented Nov 5, 2019

/trop run backport

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Nov 5, 2019

The backport process for this PR has been manually initiated, here we go! :D

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Nov 5, 2019

I was unable to backport this PR to "7-1-x" cleanly;
you will need to perform this backport manually.

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Nov 5, 2019

I have automatically backported this PR to "8-x-y", please check out #20976

@trop trop bot added in-flight/8-x-y and removed target/8-x-y labels Nov 5, 2019
MarshallOfSound added a commit that referenced this pull request Nov 5, 2019
* chore: upgrade ts generator for better type safety

* spec: fix tests
@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Nov 5, 2019

@MarshallOfSound has manually backported this PR to "7-1-x", please check out #20977

MarshallOfSound added a commit that referenced this pull request Nov 5, 2019
* chore: upgrade ts generator for better type safety

* spec: fix tests
@trop trop bot added merged/7-1-x and removed in-flight/7-1-x labels Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.