Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix broken globalShortcuts.registerAll() on non-macOS platforms #20983

Conversation

@trop
Copy link
Contributor

trop bot commented Nov 5, 2019

Backport of #20963

See that PR for details.

Notes: Fix broken globalShortcut.registerAll() on Windows and Linux

This was a regression in #16125, which unintentionally put
`GlobalShortcutListener::RegisterAccelerator` into a
`#if defined(OS_MACOSX)` block.

Notes: Fix broken `globalShortcut.registerAll()` on Windows and Linux
@codebytere codebytere merged commit 7a1b3c5 into 7-1-x Nov 6, 2019
15 of 16 checks passed
15 of 16 checks passed
build-linux Workflow: build-linux
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191105.45 succeeded
Details
electron-arm64-testing Build #20191105.46 succeeded
Details
electron-woa-testing Build #20191105.33 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Nov 6, 2019

Release Notes Persisted

Fix broken globalShortcut.registerAll() on Windows and Linux

@codebytere codebytere deleted the trop/7-1-x-bp-fix-fix-broken-globalshortcuts-registerall-on-non-macos-platforms-1572990465347 branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.