Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated <webview>.getWebContents() #20986

Merged
merged 1 commit into from Nov 8, 2019

Conversation

@miniak
Copy link
Contributor

miniak commented Nov 5, 2019

Description of Change

Remove <webview>.getWebContents() deprecated in #20726.
The issue described in #18462 can no longer happen.

Checklist

Release Notes

Notes: Removed deprecated <webview>.getWebContents().

@miniak miniak added the wip label Nov 5, 2019
@miniak miniak self-assigned this Nov 5, 2019
@electron-cation electron-cation bot added new-pr 🌱 and removed new-pr 🌱 labels Nov 5, 2019
@miniak miniak force-pushed the miniak/webview-webcontents-cleanup branch from ace23a9 to 37bc992 Nov 7, 2019
@miniak miniak changed the base branch from miniak/webview-webcontents to master Nov 7, 2019
@miniak miniak force-pushed the miniak/webview-webcontents-cleanup branch from 37bc992 to fd2a1ac Nov 7, 2019
@miniak miniak marked this pull request as ready for review Nov 7, 2019
@miniak miniak removed the wip label Nov 7, 2019
@miniak miniak requested review from nornagon, codebytere, zcbenz and deepak1556 Nov 7, 2019
Copy link
Member

nornagon left a comment

🎉

@jkleinsc jkleinsc merged commit 093f2dd into master Nov 8, 2019
14 of 15 checks passed
14 of 15 checks passed
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191107.43 succeeded
Details
electron-arm64-testing Build #20191107.43 succeeded
Details
electron-woa-testing Build #20191107.34 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Nov 8, 2019

Release Notes Persisted

Removed deprecated <webview>.getWebContents().

@jkleinsc jkleinsc deleted the miniak/webview-webcontents-cleanup branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.