Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash on exit in aura platforms with webview #21022

Merged
merged 2 commits into from Nov 7, 2019

Conversation

@deepak1556
Copy link
Member

deepak1556 commented Nov 7, 2019

Description of Change

Backports #21019

Also backports related https://chromium-review.googlesource.com/c/chromium/src/+/1771407 which is the new shared shutdown path for aura platforms, this is available in master and 8-x-y.

Checklist

Release Notes

Notes: fix crash on exit in aura platforms with webview

@deepak1556 deepak1556 requested review from zcbenz and electron/wg-releases Nov 7, 2019
@deepak1556 deepak1556 requested a review from electron/wg-upgrades as a code owner Nov 7, 2019
@trop trop bot mentioned this pull request Nov 7, 2019
3 of 6 tasks complete
@zcbenz
zcbenz approved these changes Nov 7, 2019
@jkleinsc jkleinsc merged commit 55955c3 into 7-1-x Nov 7, 2019
15 of 16 checks passed
15 of 16 checks passed
Valid Backport Invalid Backport
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191107.12 succeeded
Details
electron-arm64-testing Build #20191107.12 succeeded
Details
electron-woa-testing Build #20191107.10 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Nov 7, 2019

Release Notes Persisted

fix crash on exit in aura platforms with webview

@jkleinsc jkleinsc deleted the robo/fix_webview_destruction_7 branch Nov 7, 2019
@deepak1556 deepak1556 mentioned this pull request Nov 7, 2019
4 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.