Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor printing for mojo #21026

Merged
merged 1 commit into from Nov 8, 2019

Conversation

@codebytere
Copy link
Member

codebytere commented Nov 7, 2019

Description of Change

Closes #19008.

Fixes printing in the aftermath of its mojoification.

Checklist

Release Notes

Notes: Fixed printing.

@codebytere codebytere added the wip label Nov 7, 2019
@codebytere codebytere requested a review from electron/wg-upgrades as a code owner Nov 7, 2019
@codebytere codebytere force-pushed the printing-fixes-for-mojo branch from 122f363 to 0aff4be Nov 7, 2019
@codebytere codebytere changed the title [wip] fix: refactor printing for mojom [wip] fix: refactor printing for mojo Nov 7, 2019
@codebytere codebytere force-pushed the printing-fixes-for-mojo branch 2 times, most recently from 0188b4f to f58453d Nov 7, 2019
@codebytere codebytere changed the title [wip] fix: refactor printing for mojo fix: refactor printing for mojo Nov 7, 2019
patches/chromium/printing.patch Outdated Show resolved Hide resolved
patches/chromium/printing.patch Outdated Show resolved Hide resolved
patches/chromium/printing.patch Show resolved Hide resolved
@codebytere codebytere force-pushed the printing-fixes-for-mojo branch 2 times, most recently from 59e15e7 to d67879b Nov 8, 2019
@codebytere codebytere requested a review from nornagon Nov 8, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Nov 8, 2019
@codebytere codebytere force-pushed the printing-fixes-for-mojo branch from d67879b to f5d4f3e Nov 8, 2019
@codebytere codebytere referenced this pull request Nov 8, 2019
3 of 3 tasks complete
@jkleinsc jkleinsc merged commit 6c2af8b into master Nov 8, 2019
15 checks passed
15 checks passed
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191108.5 succeeded
Details
electron-arm64-testing Build #20191108.6 succeeded
Details
electron-woa-testing Build #20191108.7 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Nov 8, 2019

Release Notes Persisted

Fixed printing.

@jkleinsc jkleinsc deleted the printing-fixes-for-mojo branch Nov 8, 2019
@codebytere

This comment has been minimized.

Copy link
Member Author

codebytere commented Nov 8, 2019

note: this can't be backported to 8 until #20839 lands

codebytere added a commit that referenced this pull request Nov 9, 2019
@codebytere codebytere referenced this pull request Nov 9, 2019
4 of 4 tasks complete
@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Nov 9, 2019

@codebytere has manually backported this PR to "8-x-y", please check out #21059

@trop trop bot added in-flight/8-x-y and removed needs-manual-bp/8-x-y labels Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.