Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: webrequest api typings #21038

Merged
merged 2 commits into from Nov 7, 2019

Conversation

@deepak1556
Copy link
Member

deepak1556 commented Nov 7, 2019

Description of Change

This is fixed in master and 8-x-y with #19992

Checklist

Release Notes

Notes: fix webrequest api typings

@deepak1556 deepak1556 requested review from nornagon and electron/wg-releases Nov 7, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Nov 7, 2019
Copy link
Member

MarshallOfSound left a comment

Lots of the fixes in here (all except the last) aren't needed if I backport a pending PR that's already landed in master.

@deepak1556

This comment has been minimized.

Copy link
Member Author

deepak1556 commented Nov 7, 2019

if I backport a pending PR that's already landed in master.

@MarshallOfSound which PR is that ? I don't mind waiting for that PR as long as this fix gets landed in the 7-1-x at the earliest. I would like to get this along with #21022 for the next release.

@deepak1556

This comment has been minimized.

Copy link
Member Author

deepak1556 commented Nov 7, 2019

Is this the one #20977 ?

@MarshallOfSound

This comment has been minimized.

Copy link
Member

MarshallOfSound commented Nov 7, 2019

@deepak1556 Yes it's that one, I'll update this PR to take into account that fix

@deepak1556

This comment has been minimized.

Copy link
Member Author

deepak1556 commented Nov 7, 2019

Great, thanks!

@MarshallOfSound MarshallOfSound merged commit 8dd0042 into 7-1-x Nov 7, 2019
11 of 15 checks passed
11 of 15 checks passed
Valid Backport Invalid Backport
Details
appveyor: win-ia32-testing Waiting for AppVeyor build to complete
Details
appveyor: win-woa-testing Waiting for AppVeyor build to complete
Details
appveyor: win-x64-testing Waiting for AppVeyor build to complete
Details
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191107.33 succeeded
Details
electron-arm64-testing Build #20191107.33 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Nov 7, 2019

Release Notes Persisted

fix webrequest api typings

@jkleinsc jkleinsc deleted the robo/fix_webrequest_typings branch Nov 7, 2019
@sofianguy sofianguy added this to Fixed in 7.1.1 in 7.1.x Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
7.1.x
Fixed in 7.1.1
3 participants
You can’t perform that action at this time.