Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implement login event for WebContents #21097

Merged
merged 7 commits into from Nov 18, 2019
Merged

Conversation

@nornagon
Copy link
Member

nornagon commented Nov 12, 2019

Backport of #20954. See that PR for details.

Notes: Fixed the 'login' event not being emitted when HTTP Basic auth was requested from a WebContents.

@trop trop bot mentioned this pull request Nov 12, 2019
5 of 6 tasks complete
@trop trop bot added 7-1-x backport labels Nov 12, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Nov 12, 2019
nornagon added 5 commits Nov 13, 2019
shell/browser/login_handler.cc Outdated Show resolved Hide resolved
shell/browser/login_handler.cc Outdated Show resolved Hide resolved
@nornagon nornagon merged commit 16ff7b1 into 7-1-x Nov 18, 2019
15 of 16 checks passed
15 of 16 checks passed
build-mac Workflow: build-mac
Details
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
electron-arm-testing Build #20191115.14 succeeded
Details
electron-arm64-testing Build #20191115.14 succeeded
Details
electron-woa-testing Build #20191115.14 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Nov 18, 2019

Release Notes Persisted

Fixed the 'login' event not being emitted when HTTP Basic auth was requested from a WebContents.

@nornagon nornagon deleted the backport/7-1-x/login-event branch Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.