Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NativeImage serialization of <webview>.capturePage() result #21104

Merged
merged 1 commit into from Nov 14, 2019

Conversation

@miniak
Copy link
Contributor

miniak commented Nov 13, 2019

Description of Change

Backport of #20825

Checklist

Release Notes

Notes: Fixed <webview>.capturePage() resolving with an empty object instead of NativeImage instance.

@miniak miniak self-assigned this Nov 13, 2019
@trop trop bot mentioned this pull request Nov 13, 2019
5 of 5 tasks complete
@miniak miniak requested review from zcbenz and jkleinsc Nov 13, 2019
@zcbenz
zcbenz approved these changes Nov 14, 2019
@codebytere codebytere merged commit 2b84b1e into 7-1-x Nov 14, 2019
16 checks passed
16 checks passed
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191113.13 succeeded
Details
electron-arm64-testing Build #20191113.14 succeeded
Details
electron-woa-testing Build #20191113.7 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Nov 14, 2019

Release Notes Persisted

Fixed <webview>.capturePage() resolving with an empty object instead of NativeImage instance.

@codebytere codebytere deleted the miniak/fix-webview-capture-page-7-1-x branch Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.