Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backport libuv patch for uv_spawn() ENOMEM on empty env #21140

Merged
merged 1 commit into from Nov 18, 2019

Conversation

@deepak1556
Copy link
Member

deepak1556 commented Nov 15, 2019

Description of Change

Refs nodejs/node#29008

This is not needed for master and 8-x-y

Checklist

Release Notes

Notes: fix ENOMEM error with Node.js child_process when using empty options.env

@deepak1556 deepak1556 requested review from electron/wg-releases Nov 15, 2019
@deepak1556 deepak1556 removed the backport label Nov 15, 2019
@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Nov 15, 2019

@deepak1556 has manually backported this PR to "6-1-x", please check out #21141

@trop trop bot added the in-flight/6-1-x label Nov 15, 2019
@codebytere codebytere merged commit b6198b1 into 7-1-x Nov 18, 2019
14 of 16 checks passed
14 of 16 checks passed
Valid Backport Invalid Backport
Details
electron-woa-testing Build #20191115.7 had test failures
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191115.7 succeeded
Details
electron-arm64-testing Build #20191115.7 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Nov 18, 2019

Release Notes Persisted

fix ENOMEM error with Node.js child_process when using empty options.env

@codebytere codebytere deleted the robo/backport_libuv_patch_7_x branch Nov 18, 2019
@sofianguy sofianguy added this to Fixed in 6.1.5 in 6.1.x Nov 21, 2019
@sofianguy sofianguy added this to Fixed in 7.1.2 in 7.1.x Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
6.1.x
Fixed in 6.1.5
7.1.x
Fixed in 7.1.2
2 participants
You can’t perform that action at this time.