Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stream protocols sometimes flake out #21179

Conversation

@trop
Copy link
Contributor

trop bot commented Nov 18, 2019

Backport of #21113

See that PR for details.

Notes: Fixed an issue where custom protocols registered using registerStreamProtocol would sometimes fail to complete the response when the stream ended.

@trop trop bot requested a review from nornagon Nov 18, 2019
@trop trop bot mentioned this pull request Nov 18, 2019
3 of 6 tasks complete
@trop trop bot added 7-1-x backport labels Nov 18, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Nov 18, 2019
@ckerr
ckerr approved these changes Nov 18, 2019
Copy link
Member

ckerr left a comment

As commented inline, since Start() can delete this, it's probably good to add a comment warning about this potential gotcha.

shell/browser/net/node_stream_loader.cc Show resolved Hide resolved
Co-Authored-By: Charles Kerr <ckerr@github.com>
@jkleinsc

This comment has been minimized.

Copy link
Contributor

jkleinsc commented Nov 19, 2019

Merging as CI failures are flakes unrelated to this change.

@jkleinsc jkleinsc merged commit dc90c11 into 7-1-x Nov 19, 2019
14 of 16 checks passed
14 of 16 checks passed
appveyor: win-ia32-testing AppVeyor build failed
Details
electron-woa-testing Build #20191118.18 had test failures
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191118.30 succeeded
Details
electron-arm64-testing Build #20191118.30 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@jkleinsc jkleinsc deleted the trop/7-1-x-bp-fix-stream-protocols-sometimes-flake-out-1574102864576 branch Nov 19, 2019
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Nov 19, 2019

Release Notes Persisted

Fixed an issue where custom protocols registered using registerStreamProtocol would sometimes fail to complete the response when the stream ended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.