Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use python3 to download external binaries #21184

Merged
merged 2 commits into from Nov 19, 2019

Conversation

@MarshallOfSound
Copy link
Member

MarshallOfSound commented Nov 18, 2019

On master, on macOS the version of vpython chrome ships in depot tools does not have a new enough version of openssl to download things from github. This updates our script to work in both python 2 and python 3 and updates our DEPS file to use python 3 to download the external binaries.

This fixes the issue with nightlies not releasing.

Notes: no-notes

@MarshallOfSound MarshallOfSound requested a review from electron/wg-upgrades as a code owner Nov 18, 2019
@codebytere

This comment has been minimized.

Copy link
Member

codebytere commented Nov 18, 2019

Do we need to backport this to 8?

@jkleinsc

This comment has been minimized.

Copy link
Contributor

jkleinsc commented Nov 19, 2019

Merging as CI failures unrelated to PR change

@jkleinsc jkleinsc merged commit d34ba76 into master Nov 19, 2019
12 of 16 checks passed
12 of 16 checks passed
appveyor: win-x64-testing AppVeyor build failed
Details
build-linux Workflow: build-linux
Details
electron-arm-testing Build #20191119.10 failed
Details
build-mac Workflow: build-mac
Details
Artifact Comparison No Changes
Details
Backportable? - 8-x-y Clean Backport
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
electron-arm64-testing Build #20191119.10 succeeded
Details
electron-woa-testing Build #20191119.11 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Nov 19, 2019

No Release Notes

@jkleinsc jkleinsc deleted the use-python3-external branch Nov 19, 2019
@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Nov 19, 2019

I have automatically backported this PR to "8-x-y", please check out #21202

@jkleinsc

This comment has been minimized.

Copy link
Contributor

jkleinsc commented Nov 19, 2019

/trop run backport-to 7-1-x

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Nov 19, 2019

The backport process for this PR has been manually initiated -
sending your commits to "7-1-x"!

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Nov 19, 2019

I have automatically backported this PR to "7-1-x", please check out #21213

@jkleinsc

This comment has been minimized.

Copy link
Contributor

jkleinsc commented Nov 19, 2019

/trop run backport

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Nov 19, 2019

The backport process for this PR has been manually initiated, here we go! :D

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Nov 19, 2019

I was unable to backport this PR to "6-1-x" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/6-1-x label Nov 19, 2019
@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Nov 19, 2019

I was unable to backport this PR to "5-0-x" cleanly;
you will need to perform this backport manually.

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Nov 19, 2019

I have automatically backported this PR to "7-1-x", please check out #21214

@trop trop bot removed the target/7-1-x label Nov 19, 2019
jkleinsc added a commit that referenced this pull request Nov 19, 2019
* build: use python3 to download external binaries

* Update config.py

(cherry picked from commit d34ba76)
@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Nov 19, 2019

@jkleinsc has manually backported this PR to "6-1-x", please check out #21215

jkleinsc added a commit that referenced this pull request Nov 20, 2019
deepak1556 added a commit that referenced this pull request Nov 20, 2019
* build: use python3 to download external binaries (#21184)

* build: use python3 to download external binaries

* Update config.py

(cherry picked from commit d34ba76)

* update for python3

* Update all the print

* Revert "build: use python3 to download external binaries (#21184)"

This reverts commit 0f4ebda.

* Revert "Update all the print"

This reverts commit 64a423b.

* Revert "update for python3"

This reverts commit 349ccaf.

* Use older depot_tools for 6-1-x
@trop trop bot added merged/6-1-x and removed in-flight/6-1-x labels Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.