Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: handle network drive not being available #21247

Merged
merged 1 commit into from Nov 21, 2019

Conversation

@codebytere
Copy link
Member

codebytere commented Nov 21, 2019

Description of Change

Cherry-picks 1656451 to master.

Fixes The system cannot find the path specified error when trying to save source to shared network drive.

cc @jkleinsc

Checklist

Release Notes

Notes: none

Fixes 'The system cannot find the path specified' error when trying to save source to shared network drive.
@ckerr
ckerr approved these changes Nov 21, 2019
Copy link
Member

ckerr left a comment

LGTM, but do we know why the save is failing in the first place?

@jkleinsc

This comment has been minimized.

Copy link
Contributor

jkleinsc commented Nov 21, 2019

@ckerr its a network attached drive and sometimes it is unresponsive.

@MarshallOfSound MarshallOfSound merged commit 135a649 into master Nov 21, 2019
15 of 20 checks passed
15 of 20 checks passed
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191121.25 failed
Details
electron-arm-testing #20191121.25 failed
Details
electron-woa-testing Build #20191121.10 failed
Details
electron-woa-testing in progress
Details
Backportable? - 7-1-x Backport Failed
Details
Backportable? - 8-x-y Backport Failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
electron-arm64-testing Build #20191121.25 succeeded
Details
electron-arm64-testing #20191121.25 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Nov 21, 2019

No Release Notes

@MarshallOfSound MarshallOfSound deleted the check-missing-drive branch Nov 21, 2019
@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Nov 21, 2019

I was unable to backport this PR to "7-1-x" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/7-1-x label Nov 21, 2019
@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Nov 21, 2019

I was unable to backport this PR to "8-x-y" cleanly;
you will need to perform this backport manually.

@jkleinsc

This comment has been minimized.

Copy link
Contributor

jkleinsc commented Nov 22, 2019

This change isn't needed in 8-x-y or 7-1-x because we don't use the network attached drive on those branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.