Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecate setLayoutZoomLevelLimits #21296

Merged
merged 2 commits into from Dec 2, 2019
Merged

fix: deprecate setLayoutZoomLevelLimits #21296

merged 2 commits into from Dec 2, 2019

Conversation

@nornagon
Copy link
Member

nornagon commented Nov 26, 2019

Description of Change

This hasn't worked since Chromium removed it and I believe it's beyond our capacity to continue to support it. The function doesn't work, but instead of throwing an error it seems nicer to warn about it in 8.x and wait till 9.x to delete it completely.

Checklist

Release Notes

Notes: setLayoutZoomLevelLimits no longer works in Electron 8, so emit a warning message when using it. The function will be removed in Electron 9.

@nornagon nornagon requested a review from electron/wg-upgrades as a code owner Nov 26, 2019
@nornagon nornagon requested a review from jkleinsc Nov 26, 2019
@deepak1556

This comment has been minimized.

Copy link
Member

deepak1556 commented Nov 26, 2019

This was added in #8041 , the issue it mentioned was fixed in another way #8537, can you please verify if there is a regression before merging this.

@nornagon

This comment has been minimized.

Copy link
Member Author

nornagon commented Nov 26, 2019

@deepak1556 do you mean this issue? #6958

@deepak1556

This comment has been minimized.

Copy link
Member

deepak1556 commented Nov 26, 2019

Yup that one, users seem to have been using this api as a workaround to persist the zoom level across navigations but we later fixed it on electron core, just want to make sure its still fixed, so that we can remove this api safely.

@nornagon

This comment has been minimized.

Copy link
Member Author

nornagon commented Nov 26, 2019

https://gist.github.com/8ace446c40111aca67391104c2a9cc76 I tested this in a Fiddle and it seems to work OK. However, I'm not totally sure what the original failing behavior was so I can't say for certain that I didn't accidentally dodge it somehow. Wish there had been a test written :(

@electron-cation electron-cation bot removed the new-pr 🌱 label Nov 27, 2019
@nornagon nornagon merged commit 9526c55 into master Dec 2, 2019
16 of 18 checks passed
16 of 18 checks passed
electron-arm-testing Build #20191126.19 failed
Details
electron-arm-testing #20191126.19 failed
Details
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm64-testing Build #20191126.19 succeeded
Details
electron-arm64-testing #20191126.19 succeeded
Details
electron-woa-testing Build #20191126.19 succeeded
Details
electron-woa-testing #20191126.19 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Dec 2, 2019

Release Notes Persisted

setLayoutZoomLevelLimits no longer works in Electron 8, so emit a warning message when using it. The function will be removed in Electron 9.

@nornagon

This comment has been minimized.

Copy link
Member Author

nornagon commented Dec 2, 2019

/trop run backport-to 8-x-y

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Dec 2, 2019

The backport process for this PR has been manually initiated -
sending your commits to "8-x-y"!

@nornagon nornagon deleted the setlayoutzoomlimits branch Dec 2, 2019
@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Dec 2, 2019

I have automatically backported this PR to "8-x-y", please check out #21360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.