Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add hashes to the external binary downloader #21328

Merged
merged 1 commit into from Dec 1, 2019

Conversation

@MarshallOfSound
Copy link
Member

MarshallOfSound commented Nov 29, 2019

Just a thing that makes sense to do, prevents folks swapping out the uploaded binaries without us noticing.

Notes: no-notes

@MarshallOfSound MarshallOfSound force-pushed the verify-external-binary-hash branch from 720ab7f to a00558c Nov 29, 2019
@miniak
miniak approved these changes Dec 1, 2019
@MarshallOfSound MarshallOfSound merged commit 0a60f45 into master Dec 1, 2019
16 of 18 checks passed
16 of 18 checks passed
electron-arm-testing Build #20191129.1 failed
Details
electron-arm-testing #20191129.1 failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm64-testing Build #20191129.1 succeeded
Details
electron-arm64-testing #20191129.1 succeeded
Details
electron-woa-testing Build #20191129.3 succeeded
Details
electron-woa-testing #20191129.3 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Dec 1, 2019

No Release Notes

@MarshallOfSound MarshallOfSound deleted the verify-external-binary-hash branch Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.