Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix building with enable_builtin_spellchecker = false #21334

Merged
merged 1 commit into from Nov 30, 2019

Conversation

@miniak
Copy link
Contributor

miniak commented Nov 29, 2019

Description of Change

Fixes building with enable_builtin_spellchecker = false introduced in #20692

Undefined symbols for architecture x86_64:
  "SpellcheckWordIterator::Initialize(SpellcheckCharAttribute const*, bool)", referenced from:
      electron::api::SpellCheckClient::SpellCheckText() in atom_api_spell_check_client.o
  "SpellcheckWordIterator::GetNextWord(std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> >*, unsigned long*, unsigned long*)", referenced from:
      electron::api::SpellCheckClient::SpellCheckText() in atom_api_spell_check_client.o
      electron::api::SpellCheckClient::IsContraction(electron::api::SpellCheckClient::SpellCheckScope const&, std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> > const&, std::__1::vector<std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> >, std::__1::allocator<std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> > > >*) in atom_api_spell_check_client.o
  "SpellcheckWordIterator::SetText(unsigned short const*, unsigned long)", referenced from:
      electron::api::SpellCheckClient::SpellCheckText() in atom_api_spell_check_client.o
      electron::api::SpellCheckClient::IsContraction(electron::api::SpellCheckClient::SpellCheckScope const&, std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> > const&, std::__1::vector<std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> >, std::__1::allocator<std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> > > >*) in atom_api_spell_check_client.o
  "SpellcheckWordIterator::SpellcheckWordIterator()", referenced from:
      electron::api::SpellCheckClient::SpellCheckClient(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, v8::Isolate*, v8::Local<v8::Object>) in atom_api_spell_check_client.o
  "SpellcheckWordIterator::~SpellcheckWordIterator()", referenced from:
      electron::api::SpellCheckClient::~SpellCheckClient() in atom_api_spell_check_client.o
  "SpellcheckCharAttribute::SetDefaultLanguage(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)", referenced from:
      electron::api::SpellCheckClient::SpellCheckClient(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, v8::Isolate*, v8::Local<v8::Object>) in atom_api_spell_check_client.o
  "SpellcheckCharAttribute::SpellcheckCharAttribute()", referenced from:
      electron::api::SpellCheckClient::SpellCheckClient(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, v8::Isolate*, v8::Local<v8::Object>) in atom_api_spell_check_client.o
  "SpellcheckCharAttribute::~SpellcheckCharAttribute()", referenced from:
      electron::api::SpellCheckClient::~SpellCheckClient() in atom_api_spell_check_client.o
  "SpellcheckWordIterator::IsInitialized() const", referenced from:
      electron::api::SpellCheckClient::SpellCheckText() in atom_api_spell_check_client.o
      electron::api::SpellCheckClient::IsContraction(electron::api::SpellCheckClient::SpellCheckScope const&, std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> > const&, std::__1::vector<std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> >, std::__1::allocator<std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> > > >*) in atom_api_spell_check_client.o
ld: symbol(s) not found for architecture x86_64

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

@miniak miniak requested a review from MarshallOfSound Nov 29, 2019
@miniak miniak self-assigned this Nov 29, 2019
@miniak miniak force-pushed the miniak/enable_builtin_spellchecker branch from 4caa9e0 to ed63c43 Nov 29, 2019
@deepak1556 deepak1556 force-pushed the miniak/enable_builtin_spellchecker branch 2 times, most recently from 11d67a7 to d3d6ee0 Nov 30, 2019
@deepak1556 deepak1556 removed the wip label Nov 30, 2019
@miniak miniak force-pushed the miniak/enable_builtin_spellchecker branch from d3d6ee0 to 8d4f101 Nov 30, 2019
@miniak miniak requested a review from deepak1556 Nov 30, 2019
@deepak1556 deepak1556 merged commit 03824ef into master Nov 30, 2019
17 of 19 checks passed
17 of 19 checks passed
electron-arm-testing Build #20191130.6 failed
Details
electron-arm-testing #20191130.6 failed
Details
Backportable? - 8-x-y Backport Failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm64-testing Build #20191130.6 succeeded
Details
electron-arm64-testing #20191130.6 succeeded
Details
electron-woa-testing Build #20191130.6 succeeded
Details
electron-woa-testing #20191130.6 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Nov 30, 2019

No Release Notes

@deepak1556 deepak1556 deleted the miniak/enable_builtin_spellchecker branch Nov 30, 2019
@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Nov 30, 2019

I was unable to backport this PR to "8-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/8-x-y and removed target/8-x-y labels Nov 30, 2019
deepak1556 added a commit that referenced this pull request Nov 30, 2019
@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Nov 30, 2019

@deepak1556 has manually backported this PR to "8-x-y", please check out #21341

deepak1556 added a commit that referenced this pull request Dec 1, 2019
@trop trop bot added merged/8-x-y and removed in-flight/8-x-y labels Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.