Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecate setLayoutZoomLevelLimits #21360

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Dec 2, 2019

Backport of #21296

See that PR for details.

Notes: setLayoutZoomLevelLimits no longer works in Electron 8, so emit a warning message when using it. The function will be removed in Electron 9.

@trop trop bot requested a review from as a code owner Dec 2, 2019
@trop trop bot requested a review from nornagon Dec 2, 2019
@trop trop bot mentioned this pull request Dec 2, 2019
6 tasks
zcbenz
zcbenz approved these changes Dec 4, 2019
@codebytere codebytere merged commit e18c369 into 8-x-y Dec 4, 2019
17 of 19 checks passed
Loading
@release-clerk
Copy link

@release-clerk release-clerk bot commented Dec 4, 2019

Release Notes Persisted

setLayoutZoomLevelLimits no longer works in Electron 8, so emit a warning message when using it. The function will be removed in Electron 9.

Loading

@codebytere codebytere deleted the trop/8-x-y-bp-fix-deprecate-setlayoutzoomlevellimits-1575322052369 branch Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants