Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix crash on arm testing #21407

Merged
merged 1 commit into from Dec 5, 2019
Merged

ci: fix crash on arm testing #21407

merged 1 commit into from Dec 5, 2019

Conversation

@jkleinsc
Copy link
Contributor

jkleinsc commented Dec 5, 2019

Description of Change

This resolves the issue on our arm CI where it was crashing with the following error:

(electron:541): Gtk-WARNING **: 21:39:57.442: Could not load a pixbuf from 
/org/gtk/libgtk/icons/16x16/status/image-missing.png.
This may indicate that pixbuf loaders or the mime database could not be found.
**
Gtk:ERROR:../../../../gtk/gtkiconhelper.c:494:ensure_surface_for_gicon: assertion failed (error ==
NULL): Failed to load /org/gtk/libgtk/icons/16x16/status/image-missing.png: Unrecognized image 
file format (gdk-pixbuf-error-quark, 3)

Checklist

Release Notes

Notes: no-notes

@jkleinsc jkleinsc marked this pull request as ready for review Dec 5, 2019
Copy link
Member

deepak1556 left a comment

Wow thats all ? Nice! 👍

Copy link
Member

nornagon left a comment

hm... this seems like something that should/could be done in the Dockerfile at build time.

@MarshallOfSound

This comment has been minimized.

Copy link
Member

MarshallOfSound commented Dec 5, 2019

hm... this seems like something that should/could be done in the Dockerfile at build time.

It segfaults in the dockerfile 🤷‍♂

electron/build-images#1

@MarshallOfSound MarshallOfSound merged commit 63058b8 into master Dec 5, 2019
13 of 16 checks passed
13 of 16 checks passed
appveyor: win-ia32-testing Waiting for AppVeyor build to complete
Details
appveyor: win-woa-testing Waiting for AppVeyor build to complete
Details
appveyor: win-x64-testing Waiting for AppVeyor build to complete
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191205.29 succeeded
Details
electron-arm-testing #20191205.29 succeeded
Details
electron-arm64-testing Build #20191205.29 succeeded
Details
electron-arm64-testing #20191205.29 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Dec 5, 2019

No Release Notes

@MarshallOfSound MarshallOfSound deleted the fix-arm-ci branch Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.