Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load window-setup in sandboxed renderer #21416

Merged
merged 1 commit into from Jan 6, 2020

Conversation

@miniak
Copy link
Contributor

miniak commented Dec 6, 2019

Description of Change

Fixes the following issues in sandboxed renderers:

  • window.opener is null when opened with nativeWindowOpen: false
  • window.prompt() returns null instead of throwing an exception
  • document.visibilityState is broken in sandboxed <webview>

Checklist

Release Notes

Notes: Fixed an issue that could prevent communication between a sandboxed child window opened with nativeWindowOpen: false and an unsandboxed parent window. Also fixed document.visibilityState not working in sandboxed <webview>.

@miniak miniak added the wip label Dec 6, 2019
@miniak miniak self-assigned this Dec 6, 2019
@miniak miniak force-pushed the miniak/sandbox-window-setup branch 8 times, most recently from 9044d98 to cf3541d Dec 6, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Dec 7, 2019
@miniak miniak marked this pull request as ready for review Dec 7, 2019
@miniak miniak removed the wip label Dec 7, 2019
@miniak miniak requested review from nornagon, deepak1556 and zcbenz Dec 7, 2019
@zcbenz
zcbenz approved these changes Dec 7, 2019
@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Dec 8, 2019

@miniak has manually backported this PR to "8-x-y", please check out #21431

@trop trop bot added in-flight/8-x-y and removed target/8-x-y labels Dec 8, 2019
@miniak miniak removed the target/5-1-x label Dec 8, 2019
@miniak miniak force-pushed the miniak/sandbox-window-setup branch from 4812b31 to fe55df5 Dec 8, 2019
@miniak miniak force-pushed the miniak/sandbox-window-setup branch from deb0cdd to e2a3084 Jan 5, 2020
@alexeykuzmin alexeykuzmin merged commit 31c93fe into master Jan 6, 2020
17 checks passed
17 checks passed
Backportable? - 6-1-x Backport Failed
Details
Backportable? - 7-1-x Backport Failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20200105.1 succeeded
Details
electron-arm64-testing Build #20200105.1 succeeded
Details
electron-woa-testing Build #20200105.1 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jan 6, 2020

Release Notes Persisted

Fixed an issue that could prevent communication between a sandboxed child window opened with nativeWindowOpen: false and an unsandboxed parent window. Also fixed document.visibilityState not working in sandboxed <webview>.

@alexeykuzmin alexeykuzmin deleted the miniak/sandbox-window-setup branch Jan 6, 2020
@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Jan 6, 2020

I was unable to backport this PR to "6-1-x" cleanly;
you will need to perform this backport manually.

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Jan 6, 2020

I was unable to backport this PR to "7-1-x" cleanly;
you will need to perform this backport manually.

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Jan 7, 2020

@miniak has manually backported this PR to "7-1-x", please check out #21696

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Jan 7, 2020

@miniak has manually backported this PR to "6-1-x", please check out #21697

zcbenz added a commit that referenced this pull request Jan 13, 2020
@trop trop bot added merged/8-x-y and removed in-flight/8-x-y labels Jan 13, 2020
@sofianguy sofianguy added this to Fixed in 8.0.0-beta.6 in 8.0.x Jan 14, 2020
@sofianguy sofianguy added this to Fixed in 7.1.9 in 7.1.x Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
8.0.x
Fixed in 8.0.0-beta.6
7.1.x
Fixed in 7.1.9
7 participants
You can’t perform that action at this time.