Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: window menu should handle keys correctly #21453

Conversation

@trop
Copy link
Contributor

trop bot commented Dec 10, 2019

Backport of #21434

See that PR for details.

Notes: Fix a weird behaviors and crashes when controlling window menu by keys.

@trop trop bot requested a review from electron/wg-upgrades as a code owner Dec 10, 2019
@trop trop bot requested a review from zcbenz Dec 10, 2019
@trop trop bot mentioned this pull request Dec 10, 2019
4 of 6 tasks complete
@trop trop bot added 7-1-x backport labels Dec 10, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Dec 10, 2019
@codebytere codebytere merged commit 89a7bdb into 7-1-x Dec 10, 2019
19 checks passed
19 checks passed
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191210.11 succeeded
Details
electron-arm-testing #20191210.11 succeeded
Details
electron-arm64-testing Build #20191210.11 succeeded
Details
electron-arm64-testing #20191210.11 succeeded
Details
electron-woa-testing Build #20191210.10 succeeded
Details
electron-woa-testing #20191210.10 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Dec 10, 2019

Release Notes Persisted

Fix a weird behaviors and crashes when controlling window menu by keys.

@codebytere codebytere deleted the trop/7-1-x-bp-fix-window-menu-should-handle-keys-correctly-1575962171590 branch Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.