Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore accessibility window title on macOS #21466

Conversation

@trop
Copy link
Contributor

trop bot commented Dec 10, 2019

Backport of #21462

See that PR for details.

Notes: Fixed accessibility window title on macOS

Electron's `AtomNSWindow` implements `accessibilityAttributeValue` to
provide various accessibility info to the OS, including window titles.

Chromium 75 changed to Apple's newer accessibility API for window titles
in the super class that `AtomNSWindow` inherits from. macOS still
supports both the old and new style APIs, but it will prefer the new
style if it is implemented.  This means the Electron window title is
being ignored because the newer API at the Chromium level has taken
precedence.

By implementing the newer accessibility API in `AtomNSWindow`, this
restores correct accessibility window titles in macOS Electron apps.

This is a regression has been present since Electron 6.0.0 (the first
release including the Chromium change above).
@trop trop bot mentioned this pull request Dec 10, 2019
4 of 6 tasks complete
@trop trop bot added 7-1-x backport labels Dec 10, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Dec 10, 2019
@codebytere codebytere merged commit d1d3d1b into 7-1-x Dec 11, 2019
19 checks passed
19 checks passed
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191210.26 succeeded
Details
electron-arm-testing #20191210.26 succeeded
Details
electron-arm64-testing Build #20191210.26 succeeded
Details
electron-arm64-testing #20191210.26 succeeded
Details
electron-woa-testing Build #20191211.1 succeeded
Details
electron-woa-testing #20191211.1 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Dec 11, 2019

Release Notes Persisted

Fixed accessibility window title on macOS

@codebytere codebytere deleted the trop/7-1-x-bp-fix-restore-accessibility-window-title-on-macos-1576019005190 branch Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.