Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: name and expirationDate should be optional when setting cookie (7-1-x) #21481

Conversation

@trop
Copy link
Contributor

trop bot commented Dec 11, 2019

Backport of #21477

See that PR for details.

Notes: Fix cookies.set not working correctly when name or expirationDate is omitted.

…21454)

* fix: correctly set cookie date

* fix: name is not required for setting cookie

* test: clear cookie after each cookie test

* test: should test session property

* chore: style fixes
@trop trop bot requested a review from zcbenz Dec 11, 2019
@trop trop bot added 7-1-x backport labels Dec 11, 2019
@zcbenz zcbenz changed the title fix: name and expirationDate should be optional when setting cookie (8-x-y) fix: name and expirationDate should be optional when setting cookie (7-1-x) Dec 11, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Dec 11, 2019
@codebytere

This comment has been minimized.

Copy link
Member

codebytere commented Dec 11, 2019

not ok 763 session module ses.cookies should survive an app restart for persistent partition
  AssertionError: expected '010' to equal '110'
      at Context.<anonymous> (electron\spec-main\api-session-spec.js:249:47)
      at processTicksAndRejections (internal/process/task_queues.js:85:5)

is the failure - seems unrelated but also i've never seen this before so can anyone confirm before we merge?

@zcbenz

This comment has been minimized.

Copy link
Member

zcbenz commented Dec 12, 2019

is the failure - seems unrelated but also i've never seen this before so can anyone confirm before we merge?

Some PRs for master are also having the same flaky failure:
#21384

I think it is caused by crashes on exit, I'll take a look at this.

@zcbenz

This comment has been minimized.

Copy link
Member

zcbenz commented Dec 12, 2019

Having checked the CI history of https://github.com/electron/electron/commits/master, I'm merging this since it is suffering the same flaky failure with master.

@zcbenz zcbenz merged commit 281b074 into 7-1-x Dec 12, 2019
17 of 19 checks passed
17 of 19 checks passed
electron-woa-testing Build #20191211.19 had test failures
Details
electron-woa-testing #20191211.19 failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191211.16 succeeded
Details
electron-arm-testing #20191211.16 succeeded
Details
electron-arm64-testing Build #20191211.16 succeeded
Details
electron-arm64-testing #20191211.16 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Dec 12, 2019

Release Notes Persisted

Fix cookies.set not working correctly when name or expirationDate is omitted.

@zcbenz zcbenz deleted the trop/7-1-x-bp-fix-name-and-expirationdate-should-be-optional-when-setting-cookie-8-x-y--1576060484614 branch Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.