Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid Electron.dsym files in the main app bundle #21487

Merged
merged 1 commit into from Dec 12, 2019

Conversation

@deepak1556
Copy link
Member

deepak1556 commented Dec 11, 2019

Description of Change

Backports #21447

Checklist

Release Notes

Notes: remove Electron.dsym from macOS application zip

* ci: CHECK_DIST_MANIFEST in release builds

* fix: skip Electron.dSYM on macOS app zip
@trop trop bot mentioned this pull request Dec 11, 2019
3 of 6 tasks complete
@deepak1556 deepak1556 requested a review from electron/wg-releases Dec 11, 2019
@trop trop bot added 7-1-x backport labels Dec 11, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Dec 11, 2019
@zcbenz
zcbenz approved these changes Dec 12, 2019
@zcbenz zcbenz merged commit 8f728af into 7-1-x Dec 12, 2019
17 of 19 checks passed
17 of 19 checks passed
electron-woa-testing Build #20191211.25 had test failures
Details
electron-woa-testing #20191211.25 failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191211.27 succeeded
Details
electron-arm-testing #20191211.27 succeeded
Details
electron-arm64-testing Build #20191211.27 succeeded
Details
electron-arm64-testing #20191211.27 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Dec 12, 2019

Release Notes Persisted

remove Electron.dsym from macOS application zip

@zcbenz zcbenz deleted the robo/fix_release_dist_7_x branch Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.