Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: select box not rendered properly with OOPIF #21526

Merged
merged 1 commit into from Dec 16, 2019
Merged

Conversation

@deepak1556
Copy link
Member

deepak1556 commented Dec 15, 2019

Description of Change

Fixes #21152

Backports https://chromium-review.googlesource.com/c/chromium/src/+/1879597

The upstream issue will indicate the regression from 79, because that is the current stable build user tested with but this started with 78.

Checklist

Release Notes

Notes: fix black boxes with <select> tag inside <webview> and OOPIF on windows

@deepak1556 deepak1556 requested a review from electron/wg-upgrades as a code owner Dec 15, 2019
@deepak1556 deepak1556 requested a review from electron/wg-releases Dec 15, 2019
@deepak1556 deepak1556 added the 7-1-x label Dec 15, 2019
@zcbenz
zcbenz approved these changes Dec 16, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Dec 16, 2019
@codebytere codebytere merged commit ef2f058 into 7-1-x Dec 16, 2019
18 of 19 checks passed
18 of 19 checks passed
Valid Backport Invalid Backport
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191215.1 succeeded
Details
electron-arm-testing #20191215.1 succeeded
Details
electron-arm64-testing Build #20191215.1 succeeded
Details
electron-arm64-testing #20191215.1 succeeded
Details
electron-woa-testing Build #20191215.2 succeeded
Details
electron-woa-testing #20191215.2 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Dec 16, 2019

Release Notes Persisted

fix black boxes with <select> tag inside <webview> and OOPIF on windows

@codebytere codebytere deleted the robo/oopif_select_7_x branch Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.