Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update webContents.printToPDF() example for promisified API #21541

Merged
merged 1 commit into from Dec 17, 2019

Conversation

@javan
Copy link
Contributor

javan commented Dec 16, 2019

References: #16795 #17907

Notes: no-notes

References: #16795 #17907
Copy link
Member

codebytere left a comment

thanks :)

@codebytere codebytere merged commit b57d218 into electron:master Dec 17, 2019
11 checks passed
11 checks passed
Artifact Comparison No Changes
Details
Backportable? - 7-1-x Clean Backport
Details
Backportable? - 8-x-y Clean Backport
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Dec 17, 2019

No Release Notes

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Dec 17, 2019

I have automatically backported this PR to "8-x-y", please check out #21549

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Dec 17, 2019

I have automatically backported this PR to "7-1-x", please check out #21550

@javan javan deleted the javan:patch-2 branch Dec 17, 2019
@trop trop bot added merged/7-1-x and removed in-flight/7-1-x labels Dec 18, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Dec 18, 2019
@Alecyrus Alecyrus mentioned this pull request Dec 22, 2019
3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.