Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MediaKey globalShortcuts not working on macOS #21548

Merged
merged 1 commit into from Dec 17, 2019
Merged

fix: MediaKey globalShortcuts not working on macOS #21548

merged 1 commit into from Dec 17, 2019

Conversation

@codebytere
Copy link
Member

codebytere commented Dec 16, 2019

Description of Change

Backport of #21442.

See that PR for more details.

Release Notes

Notes: Fixed media-specific globalShortcuts not working on macOS.

@codebytere codebytere requested a review from electron/wg-upgrades as a code owner Dec 16, 2019
@trop trop bot mentioned this pull request Dec 16, 2019
4 of 4 tasks complete
@trop trop bot added 7-1-x backport labels Dec 16, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Dec 16, 2019
@jkleinsc jkleinsc merged commit 79aebdf into 7-1-x Dec 17, 2019
17 of 19 checks passed
17 of 19 checks passed
electron-woa-testing Build #20191217.3 had test failures
Details
electron-woa-testing #20191217.3 failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191217.3 succeeded
Details
electron-arm-testing #20191217.3 succeeded
Details
electron-arm64-testing Build #20191217.3 succeeded
Details
electron-arm64-testing #20191217.3 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Dec 17, 2019

Release Notes Persisted

Fixed media-specific globalShortcuts not working on macOS.

@jkleinsc jkleinsc deleted the media-keys-7 branch Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.