Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [extensions] background pages #21591

Merged
merged 5 commits into from Jan 13, 2020
Merged

feat: [extensions] background pages #21591

merged 5 commits into from Jan 13, 2020

Conversation

@nornagon
Copy link
Member

nornagon commented Dec 20, 2019

Description of Change

This adds support for lazy background pages when building with ENABLE_ELECTRON_EXTENSIONS. One step closer to a functional React DevTools!

NB. no release notes because this feature is still behind the ENABLE_ELECTRON_EXTENSIONS flag, which is not enabled in Electron release builds.

Ref #19447

Checklist

Release Notes

Notes: none

nornagon added 2 commits Dec 20, 2019
@nornagon nornagon mentioned this pull request Dec 20, 2019
4 of 11 tasks complete
@electron-cation electron-cation bot removed the new-pr 🌱 label Dec 21, 2019
Copy link
Member

samuelmaddock left a comment

Left a few comments. It looks surprisingly straightforward to add background page support after reading through the code, nice!

electron_paks.gni Outdated Show resolved Hide resolved
: api_client_(new extensions::ExtensionsAPIClient),
// : api_client_(new extensions::AtomExtensionsAPIClient),
: api_client_(new extensions::ElectronExtensionsAPIClient),
process_manager_delegate_(new extensions::ElectronProcessManagerDelegate),

This comment has been minimized.

Copy link
@samuelmaddock

samuelmaddock Jan 12, 2020

Member

Random thought while reading this code. It might be cool if the extensions system could be configured at startup from the JS runtime. That way only projects interested in using extensions could opt-in to initializing all of these subsystems.

@zcbenz
zcbenz approved these changes Jan 13, 2020
Copy link
Member

zcbenz left a comment

Looks good to me.

Copy link
Member

MarshallOfSound left a comment

Looking good 👍

electron_paks.gni Outdated Show resolved Hide resolved
@nornagon nornagon merged commit 8bc0c92 into master Jan 13, 2020
15 checks passed
15 checks passed
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20200113.52 succeeded
Details
electron-arm64-testing Build #20200113.52 succeeded
Details
electron-woa-testing Build #20200113.26 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jan 13, 2020

No Release Notes

@nornagon nornagon deleted the extensions-background-pages branch Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.