Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: document goma usage and add the external binaries #21622

Merged
merged 1 commit into from Jan 7, 2020

Conversation

@MarshallOfSound
Copy link
Member

MarshallOfSound commented Dec 26, 2019

Initial work at documenting Goma usage, please note that it doesn't actually work yet 馃槅We're working on it.

Notes: no-notes

@MarshallOfSound MarshallOfSound requested a review from codebytere Dec 26, 2019
@MarshallOfSound MarshallOfSound force-pushed the goma-docs branch 3 times, most recently from bcbda28 to 855811a Dec 26, 2019
@MarshallOfSound MarshallOfSound marked this pull request as ready for review Dec 27, 2019
@MarshallOfSound MarshallOfSound changed the title [WIP] build: document goma usage and add the external binaries build: document goma usage and add the external binaries Dec 27, 2019
@loc
loc approved these changes Jan 7, 2020
@MarshallOfSound

This comment has been minimized.

Copy link
Member Author

MarshallOfSound commented Jan 7, 2020

Gonna land this, we can iterate later 馃憤

@MarshallOfSound MarshallOfSound merged commit e18acb4 into master Jan 7, 2020
13 of 15 checks passed
13 of 15 checks passed
appveyor: win-ia32-testing AppVeyor build failed
Details
electron-woa-testing Build #20191227.2 was canceled
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191227.3 succeeded
Details
electron-arm64-testing Build #20191227.3 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jan 7, 2020

No Release Notes

@MarshallOfSound MarshallOfSound deleted the goma-docs branch Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.