Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SimpleURLLoaderWrapper redirects (#21566) #21645

Conversation

@trop
Copy link
Contributor

trop bot commented Dec 30, 2019

Backport of #21630

See that PR for details.

Notes: Fixed an issue in the net module where aborting a request during a redirect could cause an error to be thrown.

@trop trop bot mentioned this pull request Dec 30, 2019
1 of 2 tasks complete
@trop trop bot added 7-1-x backport labels Dec 30, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Dec 30, 2019
@zcbenz
zcbenz approved these changes Jan 1, 2020
@zcbenz zcbenz merged commit a889ec7 into 7-1-x Jan 1, 2020
14 of 16 checks passed
14 of 16 checks passed
build-mac Workflow: build-mac
Details
electron-woa-testing Build #20191231.2 had test failures
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
electron-arm-testing Build #20191231.1 succeeded
Details
electron-arm64-testing Build #20191231.1 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jan 1, 2020

Release Notes Persisted

Fixed an issue in the net module where aborting a request during a redirect could cause an error to be thrown.

@zcbenz zcbenz deleted the trop/7-1-x-bp-fix-simpleurlloaderwrapper-redirects-21566--1577749641770 branch Jan 1, 2020
@lutzroeder

This comment has been minimized.

Copy link
Contributor

lutzroeder commented Jan 4, 2020

@nornagon @zcbenz @codebytere @MarshallOfSound What would be needed to drop a 7.1.x release including this change? I haven't had much luck building the 7-1-x branch locally and master is not supported by electron-builder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.