Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Notification crash in destructor on app quit #21719

Conversation

@trop
Copy link
Contributor

trop bot commented Jan 9, 2020

Backport of #21709

See that PR for details.

Notes: Fixed a crash that would occur when Notifications were closed in concert with app termination.

@trop trop bot requested a review from codebytere Jan 9, 2020
@trop trop bot mentioned this pull request Jan 9, 2020
5 of 5 tasks complete
@trop trop bot added 7-1-x backport labels Jan 9, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 label Jan 9, 2020
@codebytere codebytere merged commit c56e5ab into 7-1-x Jan 10, 2020
14 of 16 checks passed
14 of 16 checks passed
build-mac Workflow: build-mac
Details
electron-woa-testing Build #20200109.5 had test failures
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
electron-arm-testing Build #20200109.8 succeeded
Details
electron-arm64-testing Build #20200109.8 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jan 10, 2020

Release Notes Persisted

Fixed a crash that would occur when Notifications were closed in concert with app termination.

@codebytere codebytere deleted the trop/7-1-x-bp-fix-notification-crash-in-destructor-on-app-quit-1578591773276 branch Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.