Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid contextBridge double free on garbage collection #21736

Conversation

@trop
Copy link
Contributor

trop bot commented Jan 11, 2020

Backport of #21592

See that PR for details.

Notes: Fixed a crash in contextBridge that happens on garbage collection

@trop trop bot requested a review from loc Jan 11, 2020
@trop trop bot mentioned this pull request Jan 11, 2020
4 of 4 tasks complete
@trop trop bot added 7-1-x backport labels Jan 11, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 label Jan 11, 2020
@MarshallOfSound MarshallOfSound merged commit 704cdd3 into 7-1-x Jan 11, 2020
12 of 15 checks passed
12 of 15 checks passed
appveyor: win-ia32-testing Waiting for AppVeyor build to complete
Details
appveyor: win-woa-testing Waiting for AppVeyor build to complete
Details
appveyor: win-x64-testing Waiting for AppVeyor build to complete
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20200111.2 succeeded
Details
electron-arm64-testing Build #20200111.2 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jan 11, 2020

Release Notes Persisted

Fixed a crash in contextBridge that happens on garbage collection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.