Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: responseHeaders should be Record<string, string[]> #21742

Conversation

@trop
Copy link
Contributor

trop bot commented Jan 12, 2020

Backport of #21730

See that PR for details.

Notes: Fixed responseHeaders types in electron.d.ts

@trop trop bot requested a review from miniak Jan 12, 2020
@trop trop bot mentioned this pull request Jan 12, 2020
5 of 5 tasks complete
@trop trop bot added 7-1-x backport labels Jan 12, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 label Jan 12, 2020
@zcbenz
zcbenz approved these changes Jan 13, 2020
@zcbenz zcbenz merged commit 3bd3d94 into 7-1-x Jan 13, 2020
15 of 16 checks passed
15 of 16 checks passed
electron-woa-testing Build #20200112.2 had test failures
Details
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20200112.4 succeeded
Details
electron-arm64-testing Build #20200112.4 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jan 13, 2020

Release Notes Persisted

Fixed responseHeaders types in electron.d.ts

@zcbenz zcbenz deleted the trop/7-1-x-bp-docs-responseheaders-should-be-record-string-string--1578849627087 branch Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.