Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't fallback to OpenFolderViaShell #21749

Conversation

@trop
Copy link
Contributor

trop bot commented Jan 13, 2020

Backport of #21668

See that PR for details.

Notes: Fixed an issue with potential duplicate error popups when calling shell.showItemInFolder on Windows

@trop trop bot requested a review from codebytere Jan 13, 2020
@trop trop bot mentioned this pull request Jan 13, 2020
4 of 4 tasks complete
@trop trop bot added 7-1-x backport labels Jan 13, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 label Jan 13, 2020
@zcbenz
zcbenz approved these changes Jan 13, 2020
@zcbenz zcbenz merged commit ae27218 into 7-1-x Jan 13, 2020
14 of 16 checks passed
14 of 16 checks passed
build-mac Workflow: build-mac
Details
electron-woa-testing Build #20200113.1 had test failures
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
electron-arm-testing Build #20200113.4 succeeded
Details
electron-arm64-testing Build #20200113.4 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jan 13, 2020

Release Notes Persisted

Fixed an issue with potential duplicate error popups when calling shell.showItemInFolder on Windows

@zcbenz zcbenz deleted the trop/7-1-x-bp-fix-don-t-fallback-to-openfolderviashell-1578876604258 branch Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.