Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix release asset names #21772

Merged
merged 1 commit into from Jan 14, 2020
Merged

build: fix release asset names #21772

merged 1 commit into from Jan 14, 2020

Conversation

@jkleinsc
Copy link
Contributor

jkleinsc commented Jan 14, 2020

Description of Change

#21327 introduced new release assets, but unfortunately added the wrong file names to validate on the release. This PR corrects those filenames so that we can properly validate a release.

Checklist

Release Notes

Notes: no-notes

@jkleinsc jkleinsc requested a review from electron/wg-releases as a code owner Jan 14, 2020
@codebytere

This comment has been minimized.

Copy link
Member

codebytere commented Jan 14, 2020

@jkleinsc does this need to get backported at all?

@jkleinsc

This comment has been minimized.

Copy link
Contributor Author

jkleinsc commented Jan 14, 2020

@codebytere no. The change is only in master.

@jkleinsc jkleinsc merged commit 408d3d2 into master Jan 14, 2020
15 checks passed
15 checks passed
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20200114.19 succeeded
Details
electron-arm64-testing Build #20200114.18 succeeded
Details
electron-woa-testing Build #20200114.10 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jan 14, 2020

No Release Notes

@jkleinsc jkleinsc deleted the fix-release-validation branch Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.