Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use legacy base::Value serializers for ipc (7-1-x) #21922

Merged
merged 8 commits into from Jan 31, 2020

Conversation

@nornagon
Copy link
Member

@nornagon nornagon commented Jan 27, 2020

Description of Change

This switches the serialization algorithm for base::ListValue values sent over IPC (through ipcRenderer / ipcMain) to use the legacy serialization algorithm, rather than the new Mojo algorithm. The messages themselves are still sent over Mojo.

Fixes #20334.

Checklist

Release Notes

Notes: Fixed an issue where sending complex objects over IPC could in some cases cause the renderer process to be terminated.

@nornagon
Copy link
Member Author

@nornagon nornagon commented Jan 27, 2020

This is marked [wip] because I'm yet to convert the return values of those messages to use the legacy serializers.

Loading

@nornagon nornagon requested a review from as a code owner Jan 28, 2020
@nornagon nornagon removed the wip label Jan 28, 2020
zcbenz
zcbenz approved these changes Jan 29, 2020
@zcbenz
Copy link
Member

@zcbenz zcbenz commented Jan 30, 2020

This PR requires approval from @electron/wg-upgrades.

Loading

Copy link
Contributor

@jkleinsc jkleinsc left a comment

LGTM

Loading

@nornagon
Copy link
Member Author

@nornagon nornagon commented Jan 31, 2020

arm is flake, woa is queued forever apparently. I think this is good to go 🚀

Loading

@nornagon nornagon merged commit e757601 into 7-1-x Jan 31, 2020
13 of 16 checks passed
Loading
@release-clerk
Copy link

@release-clerk release-clerk bot commented Jan 31, 2020

Release Notes Persisted

Fixed an issue where sending complex objects over IPC could in some cases cause the renderer process to be terminated.

Loading

@nornagon nornagon deleted the mojo-legacy-serializers branch Jan 31, 2020
tessus added a commit to tessus/joplin that referenced this issue Feb 12, 2020
This is only a minor bump but several issues have been fixed since 7.1.9:

- Fixed an issue where sending complex objects over IPC could in some cases cause the renderer process to be terminated. electron/electron#21922
- Fixed crash with Date.toLocaleString for invalid locale and locale of the format aa@BB. electron/electron#21969
- Fixed flash plugin not working. electron/electron#22109
- Fixed issue where renderers could crash during GC when using the contextBridge module. electron/electron#22112
- Fixed netLog.stopLogging returning undefined instead of the path to the log. electron/electron#21988
- Fixed an edge case in checkbox logic on Windows. electron/electron#21860
- Fixed an issue where window.print() only worked once on a single BrowserWindow. electron/electron#21911
- Fixed an issue where the credits set in About Panel credits were not dark mode aware on macOS. electron/electron#21924
- Fixed error thrown when importing powerMonitor on Linux before app's 'ready' event. electron/electron#21941
- Fixed fuzzy font rendering when hot-plugging displays on macOS Catalina. electron/electron#21872
- Fixed BrowserWindow.setFocusable(true) not working on Windows. electron/electron#21855
- Fixed set-cookie header not passed in net module. electron/electron#21770
- Fixed an issue where custom stream protocols would sometimes not complete responses when the data stream ended. electron/electron#21758
- Fixed crash when restoring minimized hidden window on Windows. electron/electron#21820
- Fixed issue where non-zero size pixels in CSS styles could be rounded down to zero size pixels. electron/electron#21857
- Fixed memory leak when using javascript generator functions. electron/electron#21773
- Fixed potential hang when sending synchronous IPC messages on process shutdown. electron/electron#21776
laurent22 pushed a commit to laurent22/joplin that referenced this issue Feb 13, 2020
This is only a minor bump but several issues have been fixed since 7.1.9:

- Fixed an issue where sending complex objects over IPC could in some cases cause the renderer process to be terminated. electron/electron#21922
- Fixed crash with Date.toLocaleString for invalid locale and locale of the format aa@BB. electron/electron#21969
- Fixed flash plugin not working. electron/electron#22109
- Fixed issue where renderers could crash during GC when using the contextBridge module. electron/electron#22112
- Fixed netLog.stopLogging returning undefined instead of the path to the log. electron/electron#21988
- Fixed an edge case in checkbox logic on Windows. electron/electron#21860
- Fixed an issue where window.print() only worked once on a single BrowserWindow. electron/electron#21911
- Fixed an issue where the credits set in About Panel credits were not dark mode aware on macOS. electron/electron#21924
- Fixed error thrown when importing powerMonitor on Linux before app's 'ready' event. electron/electron#21941
- Fixed fuzzy font rendering when hot-plugging displays on macOS Catalina. electron/electron#21872
- Fixed BrowserWindow.setFocusable(true) not working on Windows. electron/electron#21855
- Fixed set-cookie header not passed in net module. electron/electron#21770
- Fixed an issue where custom stream protocols would sometimes not complete responses when the data stream ended. electron/electron#21758
- Fixed crash when restoring minimized hidden window on Windows. electron/electron#21820
- Fixed issue where non-zero size pixels in CSS styles could be rounded down to zero size pixels. electron/electron#21857
- Fixed memory leak when using javascript generator functions. electron/electron#21773
- Fixed potential hang when sending synchronous IPC messages on process shutdown. electron/electron#21776
@nornagon
Copy link
Member Author

@nornagon nornagon commented Feb 24, 2020

/trop run backport-to 6-1-x

Loading

@trop
Copy link
Contributor

@trop trop bot commented Feb 24, 2020

The backport process for this PR has been manually initiated -
sending your commits to "6-1-x"!

Loading

@trop
Copy link
Contributor

@trop trop bot commented Feb 24, 2020

I was unable to backport this PR to "6-1-x" cleanly;
you will need to perform this backport manually.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants