Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use a WeakPtr so we do not UAF the store in FunctionLifetimeMonitor #22114

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Feb 9, 2020

Backport of #22056

See that PR for details.

Notes: Fixed issue where renderers could crash during GC when using the contextBridge module

zcbenz
zcbenz approved these changes Feb 10, 2020
@zcbenz zcbenz merged commit 72bccd1 into 8-x-y Feb 10, 2020
14 of 16 checks passed
Loading
@release-clerk
Copy link

@release-clerk release-clerk bot commented Feb 10, 2020

Release Notes Persisted

Fixed issue where renderers could crash during GC when using the contextBridge module

Loading

@zcbenz zcbenz deleted the trop/8-x-y-bp-fix-use-a-weakptr-so-we-do-not-uaf-the-store-in-functionlifetimemonitor-1581223796665 branch Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants