Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable pdf viewer #22131

Merged
merged 1 commit into from Feb 13, 2020
Merged

feat: enable pdf viewer #22131

merged 1 commit into from Feb 13, 2020

Conversation

@nornagon
Copy link
Member

nornagon commented Feb 11, 2020

Backport of #21794

Notes: Restored support for pdfium-based PDF viewer.

@nornagon nornagon requested a review from electron/wg-upgrades as a code owner Feb 11, 2020
@trop trop bot mentioned this pull request Feb 11, 2020
5 of 6 tasks complete
@trop trop bot added 9-x-y backport labels Feb 11, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 label Feb 12, 2020
@zcbenz
Copy link
Member

zcbenz commented Feb 12, 2020

Building is failing.

@nornagon nornagon force-pushed the backport/9-x-y/extensions-pdf branch from 32da1ec to 8d1077c Feb 13, 2020
@nornagon nornagon merged commit 0e31826 into 9-x-y Feb 13, 2020
16 checks passed
16 checks passed
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20200213.4 succeeded
Details
electron-arm64-testing Build #20200213.4 succeeded
Details
electron-woa-testing Build #20200213.5 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk
Copy link

release-clerk bot commented Feb 13, 2020

Release Notes Persisted

Restored support for pdfium-based PDF viewer.

@nornagon nornagon deleted the backport/9-x-y/extensions-pdf branch Feb 13, 2020
@sofianguy sofianguy mentioned this pull request May 13, 2020
8 of 8 tasks complete
@cyptus cyptus mentioned this pull request May 20, 2020
3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.