Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash on custom printing margins #22186

Merged
merged 1 commit into from Feb 13, 2020
Merged

fix: crash on custom printing margins #22186

merged 1 commit into from Feb 13, 2020

Conversation

@codebytere
Copy link
Member

@codebytere codebytere commented Feb 13, 2020

Backport of #22164.

See that PR for details.

Notes: Fixed a crash in webContents.print() with custom print margins.

@trop trop bot mentioned this pull request Feb 13, 2020
5 tasks
@codebytere codebytere requested a review from Feb 13, 2020
@codebytere codebytere changed the title fix: crash on custom printing margins (#22164) fix: crash on custom printing margins Feb 13, 2020
@codebytere codebytere merged commit 89607e6 into 8-x-y Feb 13, 2020
15 of 16 checks passed
Loading
@release-clerk
Copy link

@release-clerk release-clerk bot commented Feb 13, 2020

Release Notes Persisted

Fixed a crash in webContents.print() with custom print margins.

Loading

@codebytere codebytere deleted the printing-backport-8 branch Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants