Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
feat(view-api): add ImageView #22738
Description of Change
This PR adds a simple
One use of this class, is to show a splash image when the window is created, and then replace the image view with WebContents once after the page is loaded. I have a written a simple demo:
Once this is merged, I will start working on an RFC to make parts of the view APIs public, which would be a minimum set of APIs to enable implementing loading screens for apps (i.e. the APIs used by the demo above).
The feature of
Note that this PR does not touch our public API.
deepak1556 left a comment
Wondering if this conflicts with refactor from #22726 and the class should be made a pure gin wrappable, but since the trackable object comes from the base class View, the separation can't happen without some refactor chunk in this PR and that can happen separately, approving based on this.
Currently we have to use our
They probably don't need to inherit from