Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: enable JS semicolons #22783

Merged
merged 1 commit into from Mar 20, 2020
Merged

build: enable JS semicolons #22783

merged 1 commit into from Mar 20, 2020

Conversation

@MarshallOfSound
Copy link
Member

MarshallOfSound commented Mar 20, 2020

ASI is an error correcting strategy, it has exceptions instead of being a steadfast rule and all our new projects in the electron org are standardizing on prettier with semicolons enabled. This is a quick --fix run to put semicolons everywhere, making code more legible, easier to parse and standard across the electron org

Notes: no-notes

@MarshallOfSound MarshallOfSound requested a review from electron/wg-releases as a code owner Mar 20, 2020
Copy link
Contributor

jkleinsc left a comment

I wholehearted approve this change! ❤️

Copy link
Member

nornagon left a comment

I see you're going for the "number of lines changed" leaderboards :D

@MarshallOfSound MarshallOfSound merged commit 5d657de into master Mar 20, 2020
16 of 18 checks passed
16 of 18 checks passed
build-linux Workflow: build-linux
Details
electron-arm-testing Build #20200320.23 had test failures
Details
Backportable? - 7-1-x Backport Failed
Details
Backportable? - 8-x-y Backport Failed
Details
Backportable? - 9-x-y Backport Failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-mac Workflow: build-mac
Details
electron-arm64-testing Build #20200320.23 succeeded
Details
electron-woa-testing Build #20200320.17 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Mar 20, 2020

No Release Notes

@MarshallOfSound MarshallOfSound deleted the all-the-semicolons branch Mar 20, 2020
@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Mar 20, 2020

I was unable to backport this PR to "9-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/9-x-y label Mar 20, 2020
@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Mar 20, 2020

I was unable to backport this PR to "8-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/9-x-y and removed target/8-x-y labels Mar 20, 2020
@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Mar 20, 2020

I was unable to backport this PR to "7-1-x" cleanly;
you will need to perform this backport manually.

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Mar 20, 2020

@MarshallOfSound has manually backported this PR to "9-x-y", please check out #22785

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Mar 20, 2020

@MarshallOfSound has manually backported this PR to "8-x-y", please check out #22786

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Mar 20, 2020

@MarshallOfSound has manually backported this PR to "7-1-x", please check out #22787

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.