Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix missing pdf dep in chromium_src #22811

Merged
merged 1 commit into from Mar 24, 2020
Merged

Conversation

@nornagon
Copy link
Member

nornagon commented Mar 23, 2020

Description of Change

Fixes e.g.

In file included from ../../chrome/renderer/pepper/chrome_renderer_pepper_host_factory.cc:18:
../..\components/pdf/renderer/pepper_pdf_host.h(17,10): fatal error: 'components/pdf/common/pdf.mojom.h' file not found
#include "components/pdf/common/pdf.mojom.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Notes: none

@deepak1556 deepak1556 merged commit 4b0d445 into master Mar 24, 2020
15 of 16 checks passed
15 of 16 checks passed
appveyor: win-x64-testing-pr AppVeyor build failed
Details
Artifact Comparison No Changes
Details
Backportable? - 9-x-y Clean Backport
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20200323.52 succeeded
Details
electron-arm64-testing Build #20200323.52 succeeded
Details
electron-woa-testing Build #20200323.19 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Mar 24, 2020

No Release Notes

@deepak1556 deepak1556 deleted the fix-chromium-src-pdf-deps branch Mar 24, 2020
@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Mar 24, 2020

I have automatically backported this PR to "9-x-y", please check out #22814

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.