Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: heap-use-after-free in tray.popUpContextMenu #22842

Merged
merged 1 commit into from Mar 27, 2020

Conversation

@nornagon
Copy link
Member

@nornagon nornagon commented Mar 26, 2020

Description of Change

Closes #22837.

image

Checklist

Release Notes

Notes: Fixed a use-after-free error that could happen if a Tray was destroyed while showing a custom context menu.

zcbenz
zcbenz approved these changes Mar 26, 2020
ckerr
ckerr approved these changes Mar 26, 2020
@nornagon nornagon merged commit ac501e8 into master Mar 27, 2020
18 of 19 checks passed
@release-clerk
Copy link

@release-clerk release-clerk bot commented Mar 27, 2020

Release Notes Persisted

Fixed a use-after-free error that could happen if a Tray was destroyed while showing a custom context menu.

@nornagon nornagon deleted the fix-tray-context-menu-uaf branch Mar 27, 2020
@trop
Copy link
Contributor

@trop trop bot commented Mar 27, 2020

I was unable to backport this PR to "8-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

@trop trop bot commented Mar 27, 2020

I was unable to backport this PR to "7-2-x" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

@trop trop bot commented Mar 27, 2020

I was unable to backport this PR to "6-1-x" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

@trop trop bot commented Mar 27, 2020

I have automatically backported this PR to "9-x-y", please check out #22855

@trop
Copy link
Contributor

@trop trop bot commented Apr 20, 2020

@nornagon has manually backported this PR to "8-x-y", please check out #23181

@trop
Copy link
Contributor

@trop trop bot commented Apr 20, 2020

@nornagon has manually backported this PR to "7-2-x", please check out #23182

@nornagon
Copy link
Member Author

@nornagon nornagon commented Apr 20, 2020

The backport to 6.1 wasn't clean and I don't think this is a serious enough issue to warrant the effort required to do the backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants