Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick fd211b44535c from chromium #22869

Merged
merged 1 commit into from Apr 1, 2020

Conversation

@nornagon
Copy link
Member

@nornagon nornagon commented Mar 27, 2020

AudioContext HasPendingActivity unless it's closed

An AudioContext is considered to have activity if it's not closed.
Previously, suspended contexts were considered has having no activity,
but that's not quite true since the context can be resumed at any time
after. This would allow contexts to be collected prematurely even
though the context was resumed. This causes the audio thread to
access objects that are possibly deleted.

Manually tested against test case from the bug; no issues seen.

TBR=hongchan@chromium.org
(cherry picked from commit 5efc951230de524c2b6787e25ec651c46f2652b4)

Bug: 1023810
Change-Id: I81cc0aff57bf4701b3ef9c36dd72b7e8922af5b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955339
Reviewed-by: Hongchan Choi hongchan@chromium.org
Commit-Queue: Raymond Toy rtoy@chromium.org
Cr-Original-Commit-Position: refs/heads/master@{#724364}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969044
Reviewed-by: Raymond Toy rtoy@chromium.org
Cr-Commit-Position: refs/branch-heads/3987@{#158}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}

Notes: Security: backported fix for use-after-poison in WebAudio (crbug.com/1023810)

@nornagon nornagon requested a review from as a code owner Mar 27, 2020
@nornagon nornagon added the 7-2-x label Mar 27, 2020
@nornagon
Copy link
Member Author

@nornagon nornagon commented Apr 1, 2020

CI failures are unrelated; merging.

@nornagon nornagon merged commit e7fce15 into 7-2-x Apr 1, 2020
13 of 16 checks passed
@release-clerk
Copy link

@release-clerk release-clerk bot commented Apr 1, 2020

Release Notes Persisted

Security: backported fix for use-after-poison in WebAudio (crbug.com/1023810)

@nornagon nornagon deleted the cherry-pick/7-2-x/chromium/fd211b44535c branch Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants