Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick db71a0afc1d0 from chromium #22943

merged 2 commits into from Apr 6, 2020


Copy link

@nornagon nornagon commented Apr 2, 2020

Clear context from orphan handlers when BaseAudioContext is going away

When preparing to collect a BaseAudioContext, go through all the
rendering_orphan_handlers_ and deletable_orphan_handlers_ and remove
the context from the handler. This ensures that these handlers no
longer have references to the context when the BaseAudioContext is
destroyed because in some cases, these orphan handlers will get pulled
and access the context, which is already gone.

Clearing these in a prefinalizer ensures these orphan handlers don't
try to touch the context.

Manually verified that the repro case no longer reproduces.

Bug: 1062247
Change-Id: I50d083743903eb9544e09aa1ee912fc880331501
Reviewed-by: Kentaro Hara
Reviewed-by: Hongchan Choi
Commit-Queue: Raymond Toy
Cr-Commit-Position: refs/heads/master@{#751814}

Notes: Security: backported fix for use-after-poison in WebAudio.

@nornagon nornagon requested a review from as a code owner Apr 2, 2020
@nornagon nornagon added the 7-2-x label Apr 2, 2020
Copy link

@deepak1556 deepak1556 left a comment

Failing tests are not related

@nornagon nornagon merged commit 7586295 into 7-2-x Apr 6, 2020
14 of 16 checks passed
Copy link

@release-clerk release-clerk bot commented Apr 6, 2020

Release Notes Persisted

Security: backported fix for use-after-poison in WebAudio.

@nornagon nornagon deleted the cherry-pick/7-2-x/chromium/db71a0afc1d0 branch Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants