Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 728c6deeffe1 from chromium #22981

Merged
merged 5 commits into from Apr 9, 2020

Conversation

@nornagon
Copy link
Member

@nornagon nornagon commented Apr 6, 2020

Speculative fix for crashes in ~FileChooserImpl()

FileChooserImpl can outlive ListenerProxy. We should clear
FileChooserImpl::proxy_ on ~ListenerProxy().

This CL has no tests. We don't know how to reproduce crashes.

Bug: 1054260
Change-Id: I2be7a8957f2f725c51081961357ef09f6dabb823
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067819
Commit-Queue: Kent Tamura tkent@chromium.org
Reviewed-by: Avi Drissman avi@chromium.org
Reviewed-by: Matthew Denton mpdenton@chromium.org
Cr-Commit-Position: refs/heads/master@{#744142}

Notes: Security: Backported fix for use after free in file chooser.

@nornagon nornagon requested a review from as a code owner Apr 6, 2020
@nornagon nornagon added the 7-2-x label Apr 6, 2020
@nornagon nornagon requested a review from Apr 7, 2020
ppontes
ppontes approved these changes Apr 7, 2020
Copy link
Member

@deepak1556 deepak1556 left a comment

Build needs fix

@nornagon nornagon merged commit 35cb95b into 7-2-x Apr 9, 2020
15 of 16 checks passed
@release-clerk
Copy link

@release-clerk release-clerk bot commented Apr 9, 2020

Release Notes Persisted

Security: Backported fix for use after free in file chooser.

@nornagon nornagon deleted the cherry-pick/7-2-x/chromium/728c6deeffe1 branch Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants